Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port record topic fix #2004

Merged
merged 1 commit into from
Jun 6, 2023
Merged

Port record topic fix #2004

merged 1 commit into from
Jun 6, 2023

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Jun 5, 2023

🦟 Bug fix

Summary

Port fix from #1855 (Citadel). Looks like the fix was not forward ported.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <[email protected]>
@iche033 iche033 requested a review from mjcarroll as a code owner June 5, 2023 22:02
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Jun 5, 2023
@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Merging #2004 (92ea7d8) into ign-gazebo6 (568c026) will not change coverage.
The diff coverage is 0.00%.

❗ Current head 92ea7d8 differs from pull request most recent head 8229361. Consider uploading reports for the commit 8229361 to get more accurate results

@@             Coverage Diff              @@
##           ign-gazebo6    #2004   +/-   ##
============================================
  Coverage        65.37%   65.37%           
============================================
  Files              327      327           
  Lines            26996    26996           
============================================
  Hits             17649    17649           
  Misses            9347     9347           
Impacted Files Coverage Δ
src/ServerPrivate.cc 82.96% <0.00%> (ø)

@ahcorde ahcorde merged commit c0a7428 into ign-gazebo6 Jun 6, 2023
@ahcorde ahcorde deleted the fix_record_topic_6 branch June 6, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants