Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #2006 to garden: fix finding new protobuf #2020

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

scpeters
Copy link
Member

Cherry-pick #2006 to Garden. Part of osrf/homebrew-simulation#2274. Use Rebase and Merge.

…2006)

Signed-off-by: Silvio Traversaro <[email protected]>

* TriggeredPublisher: don't catch FatalException
  It has been removed from recent versions of protobuf.

Signed-off-by: Steve Peters <[email protected]>
Co-authored-by: Steve Peters <[email protected]>
@scpeters scpeters requested a review from mjcarroll as a code owner June 16, 2023 18:31
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jun 16, 2023
@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Merging #2020 (34fc165) into gz-sim7 (064f69e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 34fc165 differs from pull request most recent head 1ef7762. Consider uploading reports for the commit 1ef7762 to get more accurate results

@@           Coverage Diff            @@
##           gz-sim7    #2020   +/-   ##
========================================
  Coverage    65.01%   65.01%           
========================================
  Files          353      353           
  Lines        28621    28618    -3     
========================================
- Hits         18607    18606    -1     
+ Misses       10014    10012    -2     
Impacted Files Coverage Δ
.../systems/triggered_publisher/TriggeredPublisher.cc 84.12% <100.00%> (+0.79%) ⬆️

... and 1 file with indirect coverage changes

@scpeters scpeters merged commit 001dd9b into gz-sim7 Jun 16, 2023
@scpeters scpeters deleted the scpeters/pick_protobuf_fix_7 branch June 16, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants