Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several minor fixes #2027

Merged
merged 2 commits into from
Jul 3, 2023
Merged

Several minor fixes #2027

merged 2 commits into from
Jul 3, 2023

Conversation

shameekganguly
Copy link
Contributor

  • Copy source in ServerConfigPrivate copy constructor
  • Add anonymous namespace around helper function in ServerConfig.cc
  • Change remaining ign log macros to gz macros
  • Fix an incorrect IsEnabled call in buoyancy system
  • Directly add a few transitively added headers in performer_detector and multicopter_velocity_control systems
  • Add missing header in test/test_config.hh.in
  • Fix path comparison in src/SystemLoader_TEST.cc for bazel

Signed-off-by: Shameek Ganguly <[email protected]>
Signed-off-by: Shameek Ganguly <[email protected]>
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jun 30, 2023
@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #2027 (1e5b6f8) into gz-sim7 (3bde4b5) will increase coverage by 0.01%.
The diff coverage is 50.00%.

❗ Current head 1e5b6f8 differs from pull request most recent head dfebde4. Consider uploading reports for the commit dfebde4 to get more accurate results

@@             Coverage Diff             @@
##           gz-sim7    #2027      +/-   ##
===========================================
+ Coverage    64.98%   64.99%   +0.01%     
===========================================
  Files          353      353              
  Lines        28600    28619      +19     
===========================================
+ Hits         18585    18602      +17     
- Misses       10015    10017       +2     
Impacted Files Coverage Δ
.../plugins/component_inspector/ComponentInspector.cc 5.61% <0.00%> (ø)
src/rendering/RenderUtil.cc 39.03% <0.00%> (ø)
src/rendering/SceneManager.cc 30.90% <0.00%> (ø)
src/systems/buoyancy/Buoyancy.cc 82.25% <0.00%> (ø)
.../systems/environment_preload/EnvironmentPreload.cc 69.69% <0.00%> (ø)
.../multicopter_control/MulticopterVelocityControl.hh 100.00% <ø> (ø)
...rc/systems/performer_detector/PerformerDetector.hh 100.00% <ø> (ø)
src/systems/sensors/Sensors.cc 62.74% <ø> (ø)
src/systems/thruster/Thruster.cc 86.20% <0.00%> (ø)
src/systems/hydrodynamics/Hydrodynamics.cc 85.28% <50.00%> (ø)
... and 5 more

... and 3 files with indirect coverage changes

Copy link
Contributor

@arjo129 arjo129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these changes. LGTM.

@ahcorde ahcorde merged commit b8a8a18 into gazebosim:gz-sim7 Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants