Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds bindings for the Joint convenience class #2040

Merged
merged 34 commits into from
Aug 17, 2023
Merged

Adds bindings for the Joint convenience class #2040

merged 34 commits into from
Aug 17, 2023

Conversation

Voldivh
Copy link
Contributor

@Voldivh Voldivh commented Jul 19, 2023 •
edited
Loading

🎉 New feature

Summary

This PR creates the python bindings for the Joint convenience class.

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@Voldivh
Use alias on bindings
df9608e 
Signed-off-by: Voldivh <[email protected]>
@Voldivh Voldivh changed the title Adds the bindings for the Joint class Adds bindings for the Joint convenience class Jul 19, 2023
@Voldivh Voldivh marked this pull request as ready for review July 19, 2023 20:12
@Voldivh Voldivh requested a review from mjcarroll as a code owner July 19, 2023 20:12
@codecov
Copy link

codecov bot commented Jul 19, 2023 •
edited
Loading

Codecov Report

Merging #2040 (f18a3e1) into main (e9e2fca) will decrease coverage by 0.02%.
The diff coverage is 50.64%.

❗ Current head f18a3e1 differs from pull request most recent head 0e10d73. Consider uploading reports for the commit 0e10d73 to get more accurate results

@@            Coverage Diff             @@
##             main    #2040      +/-   ##
==========================================
- Coverage   65.44%   65.42%   -0.02%     
==========================================
  Files         315      316       +1     
  Lines       29898    29975      +77     
==========================================
+ Hits        19566    19612      +46     
- Misses      10332    10363      +31
Files Changed Coverage Δ
python/src/gz/sim/Joint.cc 50.00% <50.00%> (ø)
python/src/gz/sim/_gz_sim_pybind11.cc 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

ahcorde
ahcorde previously requested changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you going to add some tests ?

python/src/gz/sim/Joint.cc Outdated Show resolved Hide resolved
python/src/gz/sim/Joint.cc Outdated Show resolved Hide resolved
python/src/gz/sim/Joint.cc Outdated Show resolved Hide resolved
python/src/gz/sim/Joint.cc Outdated Show resolved Hide resolved
python/src/gz/sim/Joint.cc Outdated Show resolved Hide resolved
python/src/gz/sim/Joint.cc Outdated Show resolved Hide resolved
python/src/gz/sim/Joint.hh Outdated Show resolved Hide resolved
Base automatically changed from nkoenig/7-to-main to main July 20, 2023 18:06
@Voldivh Voldivh changed the base branch from main to voldivh/python_bindings_model July 26, 2023 17:41
@Voldivh Voldivh requested a review from mabelzhang as a code owner July 26, 2023 17:41
@Voldivh Voldivh force-pushed the voldivh/python_bindings_joint branch from 6ca4f0a to 4b414fd Compare July 26, 2023 17:44
@azeey azeey added the beta Targeting beta release of upcoming collection label Jul 31, 2023
@Voldivh Voldivh force-pushed the voldivh/python_bindings_model branch from b8f644f to 7998bf7 Compare August 1, 2023 18:00
@Voldivh Voldivh force-pushed the voldivh/python_bindings_joint branch from ca7ec46 to a0b8568 Compare August 1, 2023 18:10
Voldivh and others added 6 commits August 8, 2023 10:31
@Voldivh Voldivh force-pushed the voldivh/python_bindings_model branch from 7998bf7 to af115a1 Compare August 8, 2023 15:47
@Voldivh Voldivh force-pushed the voldivh/python_bindings_joint branch from 3ca2981 to 6795ee4 Compare August 8, 2023 15:56
Voldivh added 2 commits August 10, 2023 13:19
@Voldivh
Adds copy constructor
7de886c 
Signed-off-by: Voldivh <[email protected]>
@Voldivh
Removes whitespace
0608135 
Signed-off-by: Voldivh <[email protected]>
Base automatically changed from voldivh/python_bindings_model to main August 12, 2023 05:39
azeey
azeey reviewed Aug 16, 2023
View reviewed changes
python/test/joint_test.sdf Outdated Show resolved Hide resolved
python/test/joint_TEST.py Outdated Show resolved Hide resolved
python/test/joint_TEST.py Outdated Show resolved Hide resolved
python/test/joint_test.sdf Outdated Show resolved Hide resolved
@azeey azeey dismissed ahcorde’s stale review August 17, 2023 02:03

Feedback resolved

@azeey azeey merged commit 0cf11dc into main Aug 17, 2023
@azeey azeey deleted the voldivh/python_bindings_joint branch August 17, 2023 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azeey azeey azeey approved these changes

@ahcorde ahcorde ahcorde left review comments

@mjcarroll mjcarroll Awaiting requested review from mjcarroll mjcarroll is a code owner

@mabelzhang mabelzhang Awaiting requested review from mabelzhang

Assignees
No one assigned
Labels
beta Targeting beta release of upcoming collection
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Voldivh @azeey @ahcorde @mjcarroll