Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a warning if the Server method of a TestFixture is called before Finalize #2047

Merged
merged 3 commits into from
Jul 26, 2023
Merged

Adds a warning if the Server method of a TestFixture is called before Finalize #2047

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
92d43c6
Adds a warning if the `Server` method of a `TestFixture` is called
arjo129 Jul 25, 2023
c5471e5
switch to gzwarn over ignwarn
arjo129 Jul 26, 2023
eb4dc9f
ignwarn cause citadel :(
arjo129 Jul 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/TestFixture.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,13 @@ TestFixture &TestFixture::OnPostUpdate(std::function<void(
//////////////////////////////////////////////////
std::shared_ptr<Server> TestFixture::Server() const
{
if (!this->dataPtr->finalized)
{
ignwarn << "Fixture has not been finalized, any functions you attempted"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use gzwarn instead to make forward porting easier?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think gzwarn is available in citadel. It might be worth considering back porting the functionality to reduce the maintenance overhead.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not. If we go ahead and do the forward port while it's "fresh" we can minimize some pain

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, sorry. For some reason I thought they were. @mjcarroll would there be an issue if we added those to gz-common3 at some point?

<< "to hook into will not be run. It is recommended to call Finalize()"
<< "before accessing the server."
<< std::endl;
}
return this->dataPtr->server;
}