Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new sky cubemap, instead of header #2060

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Jul 28, 2023

🎉 New feature

Utilize the cubemap_uri field, instead of the message header.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@nkoenig nkoenig requested a review from mjcarroll as a code owner July 28, 2023 13:47
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Jul 28, 2023
@azeey azeey added the beta Targeting beta release of upcoming collection label Jul 31, 2023
@azeey azeey requested a review from iche033 July 31, 2023 18:29
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #2060 (7feef34) into main (29a58c5) will decrease coverage by 0.03%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

❗ Current head 7feef34 differs from pull request most recent head e887863. Consider uploading reports for the commit e887863 to get more accurate results

@@            Coverage Diff             @@
##             main    #2060      +/-   ##
==========================================
- Coverage   65.47%   65.44%   -0.03%     
==========================================
  Files         312      312              
  Lines       29810    29803       -7     
==========================================
- Hits        19517    19504      -13     
- Misses      10293    10299       +6     
Files Changed Coverage Δ
src/Conversions.cc 84.47% <100.00%> (-0.11%) ⬇️

... and 1 file with indirect coverage changes

@mjcarroll
Copy link
Contributor

@osrf-jenkins retest this please

@mjcarroll mjcarroll merged commit e68ff3b into main Aug 4, 2023
@mjcarroll mjcarroll deleted the nkoenig/sky-cubemap-update branch August 4, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection 🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants