Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new API for creating a Projector #2064

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Use new API for creating a Projector #2064

merged 1 commit into from
Jul 31, 2023

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Jul 28, 2023

🦟 Bug fix

Summary

Use the new rendering::Scene::CreateProjector API available in harmonic

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Jul 28, 2023
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #2064 (39b96ef) into main (29a58c5) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

❗ Current head 39b96ef differs from pull request most recent head b1d36ad. Consider uploading reports for the commit b1d36ad to get more accurate results

@@            Coverage Diff             @@
##             main    #2064      +/-   ##
==========================================
- Coverage   65.47%   65.45%   -0.02%     
==========================================
  Files         312      312              
  Lines       29810    29809       -1     
==========================================
- Hits        19517    19511       -6     
- Misses      10293    10298       +5     
Files Changed Coverage Δ
src/rendering/SceneManager.cc 31.00% <0.00%> (+0.02%) ⬆️

... and 1 file with indirect coverage changes

@azeey azeey added the beta Targeting beta release of upcoming collection label Jul 31, 2023
@iche033 iche033 merged commit 18b9b92 into main Jul 31, 2023
@iche033 iche033 deleted the projector_todo branch July 31, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection 🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants