Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add non concurrency to Ubuntu CI workflow #2075

Merged

Conversation

talregev
Copy link
Contributor

@talregev talregev commented Aug 12, 2023

Add non concurrency to Ubuntu CI workflow.

@talregev talregev requested a review from mjcarroll as a code owner August 12, 2023 07:56
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Aug 12, 2023
@talregev talregev force-pushed the TalR/non_concurrency_for_all_workflows branch from f83868e to 3802c24 Compare August 12, 2023 08:02
@mjcarroll
Copy link
Contributor

Can you remove trailing whitespace from .github/workflows/ci.yml so we can pass pre-commit linting?

@talregev
Copy link
Contributor Author

Can you remove trailing whitespace from .github/workflows/ci.yml so we can pass pre-commit linting?

Yes.

@talregev talregev force-pushed the TalR/non_concurrency_for_all_workflows branch from 3802c24 to dee58c6 Compare August 15, 2023 15:22
@talregev
Copy link
Contributor Author

@mjcarroll I removed trailing whitespace.
Please approve the CI that it will run the CI.

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #2075 (ad66cce) into gz-sim7 (579013f) will not change coverage.
The diff coverage is n/a.

❗ Current head ad66cce differs from pull request most recent head dee58c6. Consider uploading reports for the commit dee58c6 to get more accurate results

@@           Coverage Diff            @@
##           gz-sim7    #2075   +/-   ##
========================================
  Coverage    65.09%   65.09%           
========================================
  Files          354      354           
  Lines        28732    28732           
========================================
  Hits         18702    18702           
  Misses       10030    10030           

@talregev
Copy link
Contributor Author

@mjcarroll
Should I merge this to the gz-sim7 or the main?
Not sure how the flow of the code is working here.

@mjcarroll
Copy link
Contributor

Should I merge this to the gz-sim7 or the main?

sim7 is fine, it will get picked up in a forward port.

Copy link
Contributor

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mjcarroll mjcarroll merged commit 900a6ea into gazebosim:gz-sim7 Aug 17, 2023
@talregev talregev deleted the TalR/non_concurrency_for_all_workflows branch August 17, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants