Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version number to gz.common python binding #2093

Merged
merged 2 commits into from
Aug 25, 2023

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Aug 24, 2023

🦟 Bug fix

Fixes #2092

Summary

This also fixes a pytest warning

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

This also fixes a pytest warning

Signed-off-by: Addisu Z. Taddese <[email protected]>
@azeey azeey requested a review from scpeters August 24, 2023 23:51
@azeey azeey requested a review from mjcarroll as a code owner August 24, 2023 23:51
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Aug 24, 2023
Signed-off-by: Addisu Z. Taddese <[email protected]>
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #2093 (054d511) into main (d839caf) will increase coverage by 0.91%.
Report is 140 commits behind head on main.
The diff coverage is 72.46%.

❗ Current head 054d511 differs from pull request most recent head 66d47b6. Consider uploading reports for the commit 66d47b6 to get more accurate results

@@            Coverage Diff             @@
##             main    #2093      +/-   ##
==========================================
+ Coverage   64.48%   65.39%   +0.91%     
==========================================
  Files         341      318      -23     
  Lines       27143    30037    +2894     
==========================================
+ Hits        17502    19643    +2141     
- Misses       9641    10394     +753     
Files Changed Coverage Δ
include/gz/sim/System.hh 100.00% <ø> (ø)
include/gz/sim/Util.hh 100.00% <ø> (ø)
include/gz/sim/components/Component.hh 100.00% <ø> (ø)
include/gz/sim/detail/EntityComponentManager.hh 94.01% <ø> (+0.14%) ⬆️
include/gz/sim/gui/GuiEvents.hh 0.00% <ø> (ø)
src/Model.cc 96.15% <ø> (+0.15%) ⬆️
src/SystemLoader.cc 71.42% <ø> (+8.01%) ⬆️
src/gui/GuiEvents.cc 44.44% <ø> (+8.08%) ⬆️
src/gui/GuiRunner.cc 52.38% <ø> (+1.70%) ⬆️
src/gui/plugins/modules/EntityContextMenu.cc 18.09% <0.00%> (-1.69%) ⬇️
... and 60 more

... and 136 files with indirect coverage changes

@azeey azeey added the beta Targeting beta release of upcoming collection label Aug 25, 2023
@azeey azeey merged commit d409496 into gazebosim:main Aug 25, 2023
@azeey azeey deleted the fix_pybind_common branch August 25, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection 🎵 harmonic Gazebo Harmonic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants