Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plugin conversion error message #2094

Merged
merged 2 commits into from
Aug 25, 2023

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Aug 25, 2023

🦟 Bug fix

Fixes #1555

Summary

This fixes the error

[Err] [Conversions.cc:1791] Tried to convert SDF [world] into [plugin]

The error comes from AddSystem passing an sdf::ElementPtr that corresponds to a <world> tag instead of a <plugin> tag when it's optional _sdf element is empty, which occurs mostly in tests when AddSystem is used to add Relay plugin which doesn't have an associated SDFormat file.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Addisu Z. Taddese <[email protected]>
@azeey azeey requested a review from mjcarroll as a code owner August 25, 2023 00:22
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Aug 25, 2023
@azeey azeey added the beta Targeting beta release of upcoming collection label Aug 25, 2023
Signed-off-by: Addisu Z. Taddese <[email protected]>
@azeey azeey merged commit 46c5df3 into gazebosim:gz-sim7 Aug 25, 2023
@azeey azeey deleted the fix_plugin_conversion_error branch August 25, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection 🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Gazebo emits the error message: "Tried to convert SDF [world] into [plugin]"
3 participants