Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate entries in joint position controller GUI plugin #2101

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Aug 30, 2023

🦟 Bug fix

Fixes #2099

Summary

Prevents duplicate entries from being added to the Joint Position Controller GUI plugin.

Applies the patch from #2099. See #2099 for instructions and sdf file for reproducing the bug.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <[email protected]>
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #2101 (d1afded) into gz-sim7 (f83456f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head d1afded differs from pull request most recent head 0394b87. Consider uploading reports for the commit 0394b87 to get more accurate results

@@           Coverage Diff            @@
##           gz-sim7    #2101   +/-   ##
========================================
  Coverage    64.99%   64.99%           
========================================
  Files          356      356           
  Lines        28933    28936    +3     
========================================
+ Hits         18805    18808    +3     
  Misses       10128    10128           
Files Changed Coverage Δ
...int_position_controller/JointPositionController.cc 59.09% <100.00%> (+3.02%) ⬆️

... and 2 files with indirect coverage changes

@azeey azeey added the beta Targeting beta release of upcoming collection label Aug 31, 2023
@iche033 iche033 merged commit 967f4f1 into gz-sim7 Sep 11, 2023
@iche033 iche033 deleted the fix_joint_controller_gui branch September 11, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection 🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Joint Position Controller Bug with multiple entities.
3 participants