Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove forward-ported restriction on model loading #2104

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

mjcarroll
Copy link
Contributor

This shouldn't have been ported to gz-sim7: #2103 (comment)

@github-actions github-actions bot added the 🌱 garden Ignition Garden label Aug 31, 2023
@azeey azeey added the beta Targeting beta release of upcoming collection label Aug 31, 2023
@mjcarroll
Copy link
Contributor Author

Some new warnings about not using gz::physics::getEngineInstallDir(), but I think that is out of scope for here.

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #2104 (4dbfdeb) into gz-sim7 (f83456f) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 4dbfdeb differs from pull request most recent head 12b84d6. Consider uploading reports for the commit 12b84d6 to get more accurate results

@@             Coverage Diff             @@
##           gz-sim7    #2104      +/-   ##
===========================================
- Coverage    64.99%   64.97%   -0.02%     
===========================================
  Files          356      356              
  Lines        28933    28929       -4     
===========================================
- Hits         18805    18798       -7     
- Misses       10128    10131       +3     
Files Changed Coverage Δ
src/Server.cc 86.25% <ø> (+1.49%) ⬆️

... and 1 file with indirect coverage changes

@azeey azeey merged commit b3731d6 into gz-sim7 Aug 31, 2023
@azeey azeey deleted the mjcarroll/remove_world_restriction branch August 31, 2023 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection 🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants