Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sdformat diff drive warning #2129

Merged
merged 1 commit into from
Sep 8, 2023
Merged

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Sep 8, 2023

🦟 Bug fix

Fixes gazebosim/gazebo_test_cases#240

Summary

According with sdf definition https://github.com/gazebosim/sdformat/blob/sdf13/sdf/1.10/surface.sdf#L99-L131 there is no spinning_friction.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde ahcorde requested a review from mjcarroll as a code owner September 8, 2023 13:10
@ahcorde ahcorde self-assigned this Sep 8, 2023
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Sep 8, 2023
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #2129 (ff40c4d) into gz-sim8 (923ccee) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head ff40c4d differs from pull request most recent head fd95541. Consider uploading reports for the commit fd95541 to get more accurate results

@@             Coverage Diff             @@
##           gz-sim8    #2129      +/-   ##
===========================================
- Coverage    65.45%   65.45%   -0.01%     
===========================================
  Files          323      323              
  Lines        30704    30704              
===========================================
- Hits         20097    20096       -1     
- Misses       10607    10608       +1     

see 1 file with indirect coverage changes

📢 Have feedback on the report? Share it here.

@mjcarroll mjcarroll merged commit f44677a into gz-sim8 Sep 8, 2023
@mjcarroll mjcarroll deleted the ahcorde/8/diff_drive_warnings branch September 8, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants