Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve joint controller world visualization #2144

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Sep 13, 2023

🦟 Bug fix

Fixes gazebosim/gazebo_test_cases#273

Summary

Visualization was very poor, you should move the camera around to check the joints, and it was really hard to see them because of the colors

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #2144 (205b9ca) into gz-sim8 (d052491) will not change coverage.
Report is 1 commits behind head on gz-sim8.
The diff coverage is n/a.

❗ Current head 205b9ca differs from pull request most recent head b4c2deb. Consider uploading reports for the commit b4c2deb to get more accurate results

@@           Coverage Diff            @@
##           gz-sim8    #2144   +/-   ##
========================================
  Coverage    65.45%   65.45%           
========================================
  Files          323      323           
  Lines        30704    30704           
========================================
  Hits         20096    20096           
  Misses       10608    10608           

@mjcarroll
Copy link
Contributor

Are there any tutorial images associated with this we need to update?

@ahcorde
Copy link
Contributor Author

ahcorde commented Sep 13, 2023

Are there any tutorial images associated with this we need to update?

Nope, it's just the sdf file

@mjcarroll mjcarroll merged commit 2388193 into gz-sim8 Sep 14, 2023
@mjcarroll mjcarroll deleted the ahcorde/8/improve_joint_control_visualization branch September 14, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants