Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for controlling which joints are published by JointStatePublisher #222

Merged
merged 6 commits into from
Jul 6, 2020

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Jun 24, 2020

This preserves the default behavior of publishing all joints in a model while adding in the ability to specify which joints should be published.

Signed-off-by: Nate Koenig [email protected]

@nkoenig nkoenig requested a review from azeey June 24, 2020 19:31
@nkoenig nkoenig requested a review from chapulina as a code owner June 24, 2020 19:31
@github-actions github-actions bot added the 📜 blueprint Ignition Blueprint label Jun 24, 2020
@codecov
Copy link

codecov bot commented Jun 24, 2020

Codecov Report

Merging #222 into ign-gazebo2 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           ign-gazebo2     #222   +/-   ##
============================================
  Coverage        62.34%   62.34%           
============================================
  Files              123      123           
  Lines             6102     6102           
============================================
  Hits              3804     3804           
  Misses            2298     2298           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7843b42...85fd9e7. Read the comment docs.

Copy link
Contributor

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! Just a few minor comments

src/systems/joint_state_publisher/JointStatePublisher.cc Outdated Show resolved Hide resolved
src/systems/joint_state_publisher/JointStatePublisher.cc Outdated Show resolved Hide resolved
src/systems/joint_state_publisher/JointStatePublisher.cc Outdated Show resolved Hide resolved
test/integration/joint_state_publisher_system.cc Outdated Show resolved Hide resolved
@azeey
Copy link
Contributor

azeey commented Jun 30, 2020

The homebrew build failed due to an infrastructure issue. Restarted the build: Build Status

@nkoenig nkoenig merged commit 9a8e41f into ign-gazebo2 Jul 6, 2020
@nkoenig nkoenig deleted the joint_state_pub_restrict branch July 6, 2020 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📜 blueprint Ignition Blueprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants