Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UNIT_Server_TEST failure caused by change in behavior of gz::common::SignalHandler #2537

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Aug 22, 2024

🦟 Bug fix

Summary

gazebosim/gz-common#618 changed the way gz::common::SignalHandler works in that the callback is invoked from a separate thread. This causes a slight difference in the timing of when callbacks get called. Adding a small delay after raising a signal fixes the problem.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@azeey azeey requested a review from mjcarroll as a code owner August 22, 2024 22:40
@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label Aug 22, 2024
Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to reproduce the test failures after updating gz-common, and confirms that this fixes the test for me.

@iche033
Copy link
Contributor

iche033 commented Aug 23, 2024

CI confirms that UNIT_Server_TEST test failures are fixed. The INTEGRATION_mesh_inertia_calculation test failure on windows should be unrelated. Merging.

@iche033 iche033 merged commit 5298d46 into gazebosim:main Aug 23, 2024
9 of 10 checks passed
@azeey azeey deleted the fix_server_test branch August 23, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants