Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow zero or more key/value pairs to be added to detection header information #257

Merged
merged 2 commits into from
Jul 22, 2020
Merged

Allow zero or more key/value pairs to be added to detection header information #257

merged 2 commits into from
Jul 22, 2020

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Jul 20, 2020

Add support for zero or more

<header_data>
  <key>some key</key>
  <value>some_value</value>
</header_data>

in the performer detector.

@iche033
Copy link
Contributor

iche033 commented Jul 21, 2020

should this go into ign-gazebo2 / blueprint?

@nkoenig nkoenig changed the base branch from master to ign-gazebo2 July 21, 2020 11:35
@nkoenig
Copy link
Contributor Author

nkoenig commented Jul 21, 2020

should this go into ign-gazebo2 / blueprint?

Yup, changed.

Added a test
849d199 
Signed-off-by: Nate Koenig <[email protected]>
@nkoenig nkoenig merged commit a7fae29 into ign-gazebo2 Jul 22, 2020
@nkoenig nkoenig deleted the performer_detector_extra_header_info branch July 22, 2020 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iche033 iche033 iche033 approved these changes

@chapulina chapulina Awaiting requested review from chapulina

@maryaB-osr maryaB-osr Awaiting requested review from maryaB-osr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nkoenig @iche033