Plotting Components Plugin #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AmrElsersy <[email protected]>
Signed-off-by: AmrElsersy <[email protected]>
Signed-off-by: AmrElsersy <[email protected]>
chapulina
added
enhancement
Signed-off-by: AmrElsersy <[email protected]>
Signed-off-by: AmrElsersy <[email protected]>
Signed-off-by: AmrElsersy <[email protected]>
chapulina
suggested changes
Sep 2, 2020
Signed-off-by: AmrElsersy <[email protected]>
Signed-off-by: AmrElsersy <[email protected]>
Signed-off-by: AmrElsersy <[email protected]>
Signed-off-by: AmrElsersy <[email protected]>
Signed-off-by: AmrElsersy <[email protected]>
chapulina
added
needs upstream release
There was a problem hiding this comment.
Features worked really well. Just a small comment. After it's resolved then I think this PR will be ready.
$ ign gazebo levels.sdf
free(): invalid pointer
invalid pointer warning upon shutdown. I believe this is introduced by the plotting.cc/hh code after cross comparing with the master branch and testing the ComponentInspector code only.
chapulina
reviewed
Sep 14, 2020
Signed-off-by: AmrElsersy <[email protected]>
Signed-off-by: AmrElsersy <[email protected]>
chapulina
suggested changes
Sep 15, 2020
There was a problem hiding this comment.
There are some code checker issues 😉 Be sure to run tools/code_check.sh
./src/gui/plugins/plotting/Plotting.cc:20: Found C++ system header after other header. Should be: Plotting.h, c system, c++ system, other. [build/include_order] [4]
./src/gui/plugins/plotting/Plotting.cc:395: Redundant blank line at the end of a code block should be deleted. [whitespace/blank_line] [3]
./src/gui/plugins/plotting/Plotting.hh:126: Lines should be <= 80 characters long [whitespace/line_length] [2]
./src/gui/plugins/plotting/Plotting.hh:153: Add #include <memory> for unique_ptr<> [build/include_what_you_use] [4]
Signed-off-by: AmrElsersy <[email protected]>
chapulina
removed
the
needs upstream release
Signed-off-by: Louise Poubel <[email protected]>
chapulina
approved these changes
Sep 17, 2020
There was a problem hiding this comment.
Working for me! I pushed some minor changes on 095b1fe related to smart pointers and adding the plugin name.
Also opened gazebosim/gz-gui#125 with a few more tweaks.
Good to merge once CI is happy and @claireyywang has also approved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A plugin for handling Components Plotting that uses PlottingInterface
this includes
Making the ComponentInspector plugin items are dragable to be dragged into the plotting interface
Making a gazebo-plugin to handle charts subscription to that components and updates the plotting interface
This class diagram shows the design and the integration between it and plotting interface