Standalone gz model executable
#2724
Open
+356
−274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Saurabh Kamat <[email protected]>
Signed-off-by: Saurabh Kamat <[email protected]>
Signed-off-by: Saurabh Kamat <[email protected]>
Signed-off-by: Saurabh Kamat <[email protected]>
Signed-off-by: Saurabh Kamat <[email protected]>
Signed-off-by: Saurabh Kamat <[email protected]>
Signed-off-by: Saurabh Kamat <[email protected]>
Signed-off-by: Saurabh Kamat <[email protected]>
Signed-off-by: Saurabh Kamat <[email protected]>
Signed-off-by: Saurabh Kamat <[email protected]>
azeey
reviewed
Feb 4, 2025
src/cmd/CMakeLists.txt
Outdated
| get_property(GENERATOR_IS_MULTI_CONFIG GLOBAL PROPERTY GENERATOR_IS_MULTI_CONFIG) | ||
| if(NOT GENERATOR_IS_MULTI_CONFIG) | ||
| list(APPEND test_sources | ||
| ../gz_TEST.cc |
There was a problem hiding this comment.
Since we're not migrating gz, we should probably keep it there. Also, Should we move ModelCommandAPI_TEST.cc in this directory? Using source files from the parent directory seems odd to me.
There was a problem hiding this comment.
I have also moved gz_TEST.cc into cmd because it currently contains one model-related test
Line 284 in 4b6445f
src/cmd/CMakeLists.txt
Outdated
Comment on lines
54
to
59
| # Running `gz sim` on macOS has problems when run with /usr/bin/ruby | ||
| # due to System Integrity Protection (SIP). Try to find ruby from | ||
| # homebrew as a workaround. | ||
| if (APPLE) | ||
| find_program(BREW_RUBY ruby HINTS /usr/local/opt/ruby/bin) | ||
| endif() |
There was a problem hiding this comment.
If we're running just UNIT_ModelCommandAPI_TEST, we shouldn't have to worry about this since we won't be loading dlls.
Signed-off-by: Saurabh Kamat <[email protected]>
Signed-off-by: Saurabh Kamat <[email protected]>
Signed-off-by: Saurabh Kamat <[email protected]>
sauk2
force-pushed
the
gz-sim-executable
branch
from
a2ae8cd to
9ef3ce2
Compare
…im-executable Signed-off-by: Saurabh Kamat <[email protected]>
sauk2
force-pushed
the
gz-sim-executable
branch
from
9ef3ce2 to
e354baa
Compare
Signed-off-by: Saurabh Kamat <[email protected]>
Signed-off-by: Saurabh Kamat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Part of gazebosim/gz-tools#7
Summary
This PR introduces a standalone
gz modelexecutable, following a similar approach togz-transport. The new executable is integrated intocmdmodel.rb.in, replacing its existing functionality.The
gz simimplementation remains unchanged in this PR and will be addressed in a subsequent update. Additionally, the command-line tests (gz_TEST.cc and ModelCommandAPI_TEST.cc) are now configured to build after thegz modelexecutable is created.Test it
Check for
UNIT_gz_TESTandUNIT_ModelCommandAPI_TESTChecklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.