Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed SdfGenerator_TEST #323

Closed
wants to merge 2 commits into from
Closed

Fixed SdfGenerator_TEST #323

wants to merge 2 commits into from

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Sep 1, 2020

This PR is related with this issue #322

Signed-off-by: ahcorde [email protected]

Signed-off-by: ahcorde <[email protected]>
@ahcorde ahcorde added bug Something isn't working 🔮 dome Ignition Dome labels Sep 1, 2020
@ahcorde ahcorde requested a review from scpeters September 1, 2020 16:30
@ahcorde ahcorde requested a review from chapulina as a code owner September 1, 2020 16:30
@ahcorde ahcorde self-assigned this Sep 1, 2020
Signed-off-by: ahcorde <[email protected]>
@chapulina
Copy link
Contributor

They was fixed by #271, being merged forward in #321. How about we get that one in together with the rest of the forward-port?

@ahcorde
Copy link
Contributor Author

ahcorde commented Sep 2, 2020

sure, you can close this PR then

@chapulina
Copy link
Contributor

See #321

@chapulina chapulina closed this Sep 2, 2020
@chapulina chapulina deleted the ahcorde/fix/sdfgenerator branch September 2, 2020 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants