-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add search and sort for resource spawner #359
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Shepherd <[email protected]>
Signed-off-by: John Shepherd <[email protected]>
Signed-off-by: John Shepherd <[email protected]>
Signed-off-by: John Shepherd <[email protected]>
Signed-off-by: John Shepherd <[email protected]>
Signed-off-by: John Shepherd <[email protected]>
Signed-off-by: John Shepherd <[email protected]>
chapulina
approved these changes
Oct 1, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great, the code looks good. I just have a comment about onAccepted
for your consideration.
In the future, maybe @ColeOSRF can create a sort icon for us to place in front of the dropdown.
Signed-off-by: John Shepherd <[email protected]>
Signed-off-by: John Shepherd <[email protected]>
Signed-off-by: John Shepherd <[email protected]>
doisyg
pushed a commit
to wyca-robotics/ign-gazebo
that referenced
this pull request
Dec 13, 2020
Signed-off-by: John Shepherd <[email protected]> Signed-off-by: Guillaume Doisy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🏰 citadel
Ignition Citadel
enhancement
New feature or request
GUI
Gazebo's graphical interface (not pure Ignition GUI)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #341
This PR most of all implements a Search textfield as well as a Sort By Combo Box. It also introduces some optimizations in loading the models (stores all resources by owner at initialization, previously only the owner data was being gathered and another search for the models was done when the user clicked on each owner). Some slight formatting was changed with the QML as I thought some of it looked a little wonky, I'm still open for suggestions on the QML.
The search bar will search (case insensitive) all the names and owners of all the resources with your submitted keyword, similar to how Fuel's website does. I also added a sort by Most Recent, A - Z, Z - A, and Downloaded. The sort and search work together to display the subset of the two.
Are there any more similar organization features or sorting methods that would be desired while we're here?
Here's a small example: