-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker: update Dockerfiles to use focal images #388
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried the changes using the new Dome release. Everything seems fine except that the ignition-dome package is not yet released, should be ready tomorrow. Let's wait 48 hours to give this a final run. Thanks @russkel for the changes!
@@ -154,7 +154,7 @@ Docker has two available versions: Community Edition (CE) and Enterprise Edition | |||
|
|||
1. Verify the installation: | |||
|
|||
docker run --runtime=nvidia --rm nvidia/cuda nvidia-smi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand it correctly, this change is not strictly related to the update to focal but more about the version of docker in the user system. I think we can update it as you did in the PR since modern docker uses the native nvidia integration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is correct. I decided to update to reflect the docs found at https://docs.nvidia.com/datacenter/cloud-native/container-toolkit/install-guide.html#docker to hopefully reduce confusion.
I'm not too familiar with what is actually going on in docker/nvidia-runtime internals so maybe this change in CLI arguments is required.
@russkel now that dome in released, we are fine to merge these changes. I would need a couple of things from you: could you please rebase/merge the changes on |
* runtime=nvidia is deprecated, gpus=all has replaced it in newer versions of docker Signed-off-by: Russ Webber <[email protected]>
Hi @j-rivero, done as you have asked. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks you very much! ready to go.
To close #382
versions of docker
This has not been built or tested by me.