Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Enable alpha based transparency on PBR materials by default #249 #415

Closed
wants to merge 2 commits into from

Conversation

chapulina
Copy link
Contributor

Backporting #249 to improve transparent materials on Citadel.

It changes the default behavior, but most likely no users are using materials with alpha yet. That's the hope 🤞

@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Oct 16, 2020
@luca-della-vedova
Copy link
Member

luca-della-vedova commented Oct 16, 2020

Ah in hindsight this needs the SetAlphaFromTexture function that was added in ign-rendering4 for Dome so it wouldn't compile without backporting that PR as well.
Since the BaseMaterial class doesn't use PIMPL I believe the addition of the needed member variable that was needed would break ABI, so it is probably not possible to backport this PR?

@chapulina
Copy link
Contributor Author

Ahh you're right 😢 That's probably why it initially targeted Dome... 😕

@chapulina chapulina closed this Oct 16, 2020
@chapulina chapulina deleted the chapulina/3/249 branch October 16, 2020 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants