Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new backpack version in tests #455

Merged
merged 1 commit into from
Nov 11, 2020
Merged

Use new backpack version in tests #455

merged 1 commit into from
Nov 11, 2020

Conversation

chapulina
Copy link
Contributor

A new version has been uploaded for this model, and this is causing test failures.

This is the quick fix. The best fix would be to rely on a "test" model which we know won't be changed.

@chapulina chapulina added the tests Broken or missing tests / testing infra label Nov 10, 2020
@github-actions github-actions bot added the 📜 blueprint Ignition Blueprint label Nov 10, 2020
@codecov
Copy link

codecov bot commented Nov 10, 2020

Codecov Report

Merging #455 (e016dcb) into ign-gazebo2 (59babe6) will increase coverage by 24.16%.
The diff coverage is 76.03%.

Impacted file tree graph

@@               Coverage Diff                @@
##           ign-gazebo2     #455       +/-   ##
================================================
+ Coverage        53.78%   77.94%   +24.16%     
================================================
  Files              121      187       +66     
  Lines             5838    10208     +4370     
================================================
+ Hits              3140     7957     +4817     
+ Misses            2698     2251      -447     
Impacted Files Coverage Δ
include/ignition/gazebo/EntityComponentManager.hh 100.00% <ø> (ø)
include/ignition/gazebo/Server.hh 100.00% <ø> (ø)
include/ignition/gazebo/ServerConfig.hh 100.00% <ø> (ø)
...nclude/ignition/gazebo/components/Serialization.hh 61.29% <0.00%> (+61.29%) ⬆️
src/SimulationRunner.cc 95.19% <ø> (+24.44%) ⬆️
.../plugins/component_inspector/ComponentInspector.cc 9.41% <0.00%> (ø)
src/gui/plugins/entity_tree/EntityTree.cc 10.52% <ø> (ø)
src/gui/plugins/modules/EntityContextMenu.cc 19.14% <ø> (ø)
src/gui/plugins/shapes/Shapes.cc 31.25% <ø> (ø)
.../gui/plugins/transform_control/TransformControl.cc 33.33% <ø> (ø)
... and 153 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99178d7...e016dcb. Read the comment docs.

@azeey azeey merged commit 65fd2dc into ign-gazebo2 Nov 11, 2020
@azeey azeey deleted the chapulina/backpack branch November 11, 2020 00:27
doisyg pushed a commit to wyca-robotics/ign-gazebo that referenced this pull request Dec 13, 2020
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Guillaume Doisy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📜 blueprint Ignition Blueprint tests Broken or missing tests / testing infra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants