Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make topics configurable for joint controllers #584

Merged
merged 2 commits into from
Feb 9, 2021

Conversation

chapulina
Copy link
Contributor

This should help with #447

Note that I didn't bother using AsValidTopic because that's only useful from Dome.

@codecov
Copy link

codecov bot commented Jan 26, 2021

Codecov Report

Merging #584 (ec90f95) into ign-gazebo3 (4eda53f) will increase coverage by 0.04%.
The diff coverage is 50.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo3     #584      +/-   ##
===============================================
+ Coverage        77.66%   77.70%   +0.04%     
===============================================
  Files              208      208              
  Lines            11595    11599       +4     
===============================================
+ Hits              9005     9013       +8     
+ Misses            2590     2586       -4     
Impacted Files Coverage Δ
src/systems/joint_controller/JointController.cc 85.18% <50.00%> (-0.90%) ⬇️
...int_position_controller/JointPositionController.cc 77.55% <50.00%> (-0.58%) ⬇️
src/SimulationRunner.cc 94.53% <0.00%> (+1.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4eda53f...ec90f95. Read the comment docs.

@chapulina chapulina requested a review from ahcorde February 8, 2021 19:49
@ahcorde
Copy link
Contributor

ahcorde commented Feb 9, 2021

@osrf-jenkins retest this please

@chapulina chapulina merged commit ac10892 into ign-gazebo3 Feb 9, 2021
@chapulina chapulina deleted the chapulina/3/joint_topics branch February 9, 2021 17:48
This was referenced Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants