-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added screenshot to toolbar #588
Conversation
Codecov Report
@@ Coverage Diff @@
## ign-gazebo3 #588 +/- ##
===============================================
+ Coverage 77.86% 77.90% +0.03%
===============================================
Files 212 210 -2
Lines 11719 11648 -71
===============================================
- Hits 9125 9074 -51
+ Misses 2594 2574 -20
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the suggestions on gazebosim/gz-gui#171 and #598, the ign-gui
plugin can be used with both ign-gazebo
and ign-gui
, so we don't need to duplicate the logic here.
If you think those changes are ok, I'd suggest we update this pull request to:
- Remove all the changes to
Scene3D
- Add the screenshot plugin from
ign-gui
to gui.config next to the shapes on the grey toolbar.
Signed-off-by: Jenn Nguyen <[email protected]>
850f5ef
to
575bca4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! We just need an ign-gui
release before merging: gazebosim/gz-gui#188
Signed-off-by: Jenn Nguyen <[email protected]>
All the test failures seem to be due to a problem on Ignition Fuel's server, it's timing out:
I think we can ignore them and merge this. |
Closes gazebosim/gz-gui#95Added a screenshot service which saves an image of the current 3D scene from the user camera.
This depends on the ign-gui screenshot plugin gazebosim/gz-gui#170
Depends on gazebosim/gz-gui#170
Updated gui.config toolbar layout to use x / y positions instead of anchors and to contain the screenshot plugin.