Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add /image suffix to thermal camera topic name #606

Merged
merged 2 commits into from
Feb 3, 2021
Merged

Add /image suffix to thermal camera topic name #606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46eb870
add image suffix to thermal camera topic name
iche033 Feb 3, 2021
83264b3
Merge branch 'main' into thermal_topic_suffix
chapulina Feb 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Migration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,13 @@ release will remove the deprecated code.
`const std::vector<Entity> &` instead of forcing a copy. The calling code
should create a copy if it needs to modify the vector in some way.

* Default generated topic name for thermal cameras now includes the `/image`
suffix. The `camera_info` topic has also been fixed to include the sensor
name in the generated topic string. The naming scheme should be consistent
with a normal camera sensor. Topic changes:
* `/<prefix>/<sensor_name>` -> `/<prefix>/<sensor_name>/image`
* `/<prefix>/camera_info` -> `/<prefix>/<sensor_name>/camera_info`

## Ignition Gazebo 4.0.0 to 4.X.X

* Ignition Gazebo 4.0.0 enabled double sided material by default but this
Expand Down
2 changes: 1 addition & 1 deletion src/rendering/RenderUtil.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -645,7 +645,7 @@ void RenderUtilPrivate::CreateRenderingEntities(
const std::string cameraSuffix{"/image"};
const std::string depthCameraSuffix{"/depth_image"};
const std::string rgbdCameraSuffix{""};
const std::string thermalCameraSuffix{""};
const std::string thermalCameraSuffix{"/image"};
const std::string gpuLidarSuffix{"/scan"};

// Treat all pre-existent entities as new at startup
Expand Down