Added light intensity #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ahcorde <[email protected]>
ahcorde
added
needs upstream release
iche033
reviewed
Feb 4, 2021
|
@osrf-jenkins retest this please |
|
there is a related test failure: |
Signed-off-by: ahcorde <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #612 +/- ##
==========================================
- Coverage 77.43% 77.33% -0.10%
==========================================
Files 212 212
Lines 12016 12018 +2
==========================================
- Hits 9304 9294 -10
- Misses 2712 2724 +12
Continue to review full report at Codecov.
|
|
@osrf-jenkins retest this please |
|
@osrf-jenkins retest this please |
1 similar comment
|
@osrf-jenkins retest this please |
chapulina
removed
the
needs upstream release
|
@iche033 CI is green! |
iche033
approved these changes
Feb 11, 2021
chapulina
approved these changes
Feb 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added light intensity. Related with this issue gazebosim/gz-rendering#232
Need some releases:
Signed-off-by: ahcorde [email protected]