-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performer count #652
Performer count #652
Conversation
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed a small typo. 7554335
Looks good to me.
Codecov Report
@@ Coverage Diff @@
## ign-gazebo4 #652 +/- ##
===============================================
- Coverage 64.77% 64.74% -0.04%
===============================================
Files 232 232
Lines 16590 16619 +29
===============================================
+ Hits 10747 10760 +13
- Misses 5843 5859 +16
Continue to review full report at Codecov.
|
🎉 New feature
Summary
The performer detector will send information about when a performer enters or leaves a region, but does not include the number of entities in the region. The count is useful when, for example, a user wants to turn off a fog emitter only when the last robot leaves a region.
Test it
ign gazebo -v 4 performer_detector.sdf
ign topic -t "/model/vehicle_blue/cmd_vel" -m ignition.msgs.Twist -p "linear: {x: 0.5}"
ign topic -et /performer_detector
You should see the following when the robot enters the region:
and this when the robot leaves
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge