Check empty world name in Scene3d #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-gazebo4 #662 +/- ##
===============================================
- Coverage 65.03% 65.00% -0.03%
===============================================
Files 232 232
Lines 16640 16640
===============================================
- Hits 10821 10817 -4
- Misses 5819 5823 +4
Continue to review full report at Codecov.
|
ahcorde
approved these changes
Mar 3, 2021
chapulina
approved these changes
Mar 3, 2021
Signed-off-by: Ian Chen <[email protected]>
adlarkin
pushed a commit
that referenced
this pull request
Mar 15, 2021
Signed-off-by: Ian Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ian Chen [email protected]
🦟 Bug fix
Summary
When loading a world with large complex meshes, I get a spam of the following msg:
This happens because the server takes a while to load while the gui is already up and running and it keeps checking for the RenderEngineGuiPlugin component on every update (and stops checking only when the it gets the world entity form the sever). In simple worlds, this does not happen because the server is usually loaded quite fast and have the world entity ready for gui on initalization.
This PR adds a check on the Scene3d plugin side so that it does not attempt to find the world's
RenderEngineGuiPlugincomponent if the world entity is not ready yet.To test
run ign gazebo with a complex world, e.g.
You should see a few
RenderEngineGuiPlugin component not foundmsgs printed in the console.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge