Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Fix README hyperlinks #68

Merged
merged 3 commits into from
Apr 20, 2020
Merged

Conversation

tykurtz
Copy link
Contributor

@tykurtz tykurtz commented Apr 20, 2020

Fixes the slightly annoying problem of the markdown links not working in README.md.

Reproduce this by clicking hyperlinks in ignitionrobotics/ign-gazebo/README.md

Verify this fixes it by clicking the hyperlinks in tykurtz/ign-gazebo/README.md

Copy link
Contributor

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@chapulina
Copy link
Contributor

chapulina commented Apr 20, 2020

Thanks for the PR. I believe the links used that pattern so that they worked on BitBucket. And then we adapted our website* so that the links work there as well. We should make sure that this pattern also works there.

CC @nkoenig

* which hasn't been updated to point to GitHub yet

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just checked the web app's source code and the new links should also work on https://ignitionrobotics.org/docs

@chapulina chapulina merged commit 8c748ea into gazebosim:master Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants