-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a flag to force headless rendering mode #701
Conversation
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #701 +/- ##
==========================================
- Coverage 63.28% 63.27% -0.02%
==========================================
Files 238 239 +1
Lines 19423 19445 +22
==========================================
+ Hits 12292 12303 +11
- Misses 7131 7142 +11
Continue to review full report at Codecov.
|
I think the word "headless" can be confusing to Gazebo users. We often use that word to refer to a server-only simulation, without the GUI process. Maybe |
Signed-off-by: ahcorde <[email protected]>
…nrobotics/ign-gazebo into ahcorde/feature/headless
Signed-off-by: ahcorde <[email protected]>
@mjcarroll @chapulina open for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just have some minor comments, but the changes LGTM. I haven't tried actually running it headless with the upstream PR though.
I think it would be best to merge this only after gazebosim/gz-rendering#272 gets in, so the functionality is working.
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tried the flag and it works for me, but I haven't tried it in a container without access to the display.
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: ahcorde <[email protected]> Signed-off-by: Louise Poubel <[email protected]> Co-authored-by: Ian Chen <[email protected]> Co-authored-by: Louise Poubel <[email protected]> Signed-off-by: William Lew <[email protected]>
🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸
🎉 New feature
Summary
This PR depends on gazebosim/gz-rendering#272. This will allow to use the flag
--headless
to force ignition-rendering to use the headless mode if it's available.Test it
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge