Banana for Scale

[mjcarroll]

🎉 Banana for Scale

Summary

It is frequently difficult to communicate scale in a robotics simulation. This plugin gives users the ability to insert bananas as a scale reference. This adds two scales of bananas for scale: a normal banana and a big banana. Users can insert the appropriate scale for their application.

The banana model is a photogrammetry reconstruction from @ColeOSRF. The markings on the side give additional scale context.

Test it

Start ignition gazebo and load the "Banana for Scale" plugin. Insert bananas for scale.

Checklist

• Signed all commits for DCO
• Added tests
• Added example and/or tutorial
• Updated documentation (as needed)
• Updated migration guide (as needed)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

[PeterMitrano]

[nindoja]

Unencoded spaces in a URL. For shame!

[codecov]

Codecov Report

Merging #734 (bbdb2a7) into ign-gazebo5 (f9e3332) will decrease coverage by 0.04%.
The diff coverage is 35.13%.

❗ Current head bbdb2a7 differs from pull request most recent head 6d85f6a. Consider uploading reports for the commit 6d85f6a to get more accurate results

@@               Coverage Diff               @@
##           ign-gazebo5     #734      +/-   ##
===============================================
- Coverage        65.31%   65.27%   -0.05%     
===============================================
  Files              240      242       +2     
  Lines            17635    17642       +7     
===============================================
- Hits             11519    11515       -4     
- Misses            6116     6127      +11     

Impacted Files	Coverage Δ
src/gui/plugins/banana_for_scale/BananaForScale.cc	33.33% <33.33%> (ø)
src/gui/plugins/banana_for_scale/BananaForScale.hh	100.00% <100.00%> (ø)
src/systems/physics/Physics.cc	69.40% <0.00%> (-0.04%)	⬇️
include/ignition/gazebo/gui/GuiEvents.hh	0.00% <0.00%> (ø)
src/rendering/RenderUtil.cc	42.14% <0.00%> (+0.04%)	⬆️
.../plugins/component_inspector/ComponentInspector.cc	7.20% <0.00%> (+0.16%)	⬆️
src/systems/physics/EntityFeatureMap.hh	94.54% <0.00%> (+0.89%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fa9e36...6d85f6a. Read the comment docs.

[caguero]

Does it make sense to add another two extra bananas in imperial units?

[darwinpanderson]

This is excellent, though I've a few clients with files that I need to support legacy measurements on. Any chance we might see the addition of an Imperial Plantain in the future along side your Metric Banana?

[chapulina]

a normal banana and a big banana

Can you be more specific? How big is a "normal" banana? 🤔

[drewbrew]

How hard would it be to add a plantain for comparison? I could really go for some tostones.

[chapulina]

Works great 🍌

[chapulina]

I took the liberty of slipping in some trivial changes in 6d85f6a. Let's get this in!