Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depend on ign-rendering 3.5 #867

Merged
merged 2 commits into from
Jun 18, 2021
Merged

Conversation

chapulina
Copy link
Contributor

This version is required since #819 and #825.

We should always bump the version on CMakeLists to provide users feedback about why their version combination may not be compiling.

We should also update the dependency version on -release repo (in this case https://github.com/ignition-release/ign-gazebo3-release), when we make a new release.

Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina added the rendering Involves Ignition Rendering label Jun 18, 2021
@chapulina chapulina requested a review from ahcorde June 18, 2021 00:18
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Jun 18, 2021
@codecov
Copy link

codecov bot commented Jun 18, 2021

Codecov Report

Merging #867 (36600a1) into ign-gazebo3 (01fc2ff) will increase coverage by 12.23%.
The diff coverage is 90.52%.

❗ Current head 36600a1 differs from pull request most recent head 1263aca. Consider uploading reports for the commit 1263aca to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           ign-gazebo3     #867       +/-   ##
================================================
+ Coverage        65.71%   77.94%   +12.23%     
================================================
  Files              127      215       +88     
  Lines             6238    12077     +5839     
================================================
+ Hits              4099     9414     +5315     
- Misses            2139     2663      +524     
Impacted Files Coverage Δ
include/ignition/gazebo/EntityComponentManager.hh 100.00% <ø> (ø)
include/ignition/gazebo/Link.hh 100.00% <ø> (ø)
include/ignition/gazebo/Model.hh 100.00% <ø> (ø)
include/ignition/gazebo/SdfEntityCreator.hh 100.00% <ø> (ø)
include/ignition/gazebo/Server.hh 100.00% <ø> (ø)
include/ignition/gazebo/ServerConfig.hh 100.00% <ø> (ø)
include/ignition/gazebo/System.hh 100.00% <ø> (ø)
include/ignition/gazebo/components/Component.hh 100.00% <ø> (ø)
include/ignition/gazebo/gui/GuiEvents.hh 0.00% <0.00%> (ø)
src/SimulationRunner.hh 100.00% <ø> (ø)
... and 197 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7876ca3...1263aca. Read the comment docs.

@chapulina chapulina merged commit 8abfc3b into ign-gazebo3 Jun 18, 2021
@chapulina chapulina deleted the chapulina/3/rendering_bump branch June 18, 2021 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel rendering Involves Ignition Rendering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants