Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blender sdf export tutorial #895

Merged
merged 8 commits into from
Jul 12, 2021
Merged

Add blender sdf export tutorial #895

merged 8 commits into from
Jul 12, 2021

Conversation

ddengster
Copy link
Contributor

@ddengster ddengster commented Jun 29, 2021

Signed-off-by: ddengster [email protected]

🎉 New feature

Summary

Adds a blender script to export models in the sdf format, accompanied with a simple tutorial as to how to use it.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: ddengster <[email protected]>
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Jun 29, 2021
@ddengster ddengster marked this pull request as ready for review June 29, 2021 10:07
@ddengster ddengster requested a review from chapulina as a code owner June 29, 2021 10:07
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the script! It has a lot of hardcoded values for things like casting shadows and bitmasks, but I think that this is a nice starting point that users can adapt to their needs. It would be nice to move these values to the top of the script to call attention to the fact that they can be customized.

tutorials/blender_sdf_exporter.md Outdated Show resolved Hide resolved
examples/scripts/blender/sdf_exporter.py Show resolved Hide resolved
examples/scripts/blender/sdf_exporter.py Outdated Show resolved Hide resolved
examples/scripts/blender/sdf_exporter.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 12, 2021

Codecov Report

Merging #895 (3aaabae) into ign-gazebo5 (d3ee64a) will increase coverage by 0.28%.
The diff coverage is 63.28%.

❗ Current head 3aaabae differs from pull request most recent head 9d93d7d. Consider uploading reports for the commit 9d93d7d to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo5     #895      +/-   ##
===============================================
+ Coverage        65.32%   65.61%   +0.28%     
===============================================
  Files              240      243       +3     
  Lines            17624    18303     +679     
===============================================
+ Hits             11513    12009     +496     
- Misses            6111     6294     +183     
Impacted Files Coverage Δ
include/ignition/gazebo/EntityComponentManager.hh 100.00% <ø> (ø)
include/ignition/gazebo/SdfEntityCreator.hh 100.00% <ø> (ø)
.../plugins/component_inspector/ComponentInspector.cc 6.69% <0.00%> (-0.52%) ⬇️
src/gui/plugins/scene3d/Scene3D.hh 50.00% <ø> (-16.67%) ⬇️
src/gui/plugins/shapes/Shapes.cc 22.72% <ø> (ø)
.../gui/plugins/transform_control/TransformControl.cc 18.00% <0.00%> (+2.87%) ⬆️
src/rendering/SceneManager.cc 24.88% <0.00%> (-0.20%) ⬇️
...ms/joint_traj_control/JointTrajectoryController.cc 78.20% <ø> (ø)
...ms/joint_traj_control/JointTrajectoryController.hh 100.00% <ø> (ø)
src/systems/physics/Physics.hh 100.00% <ø> (ø)
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb8d67a...9d93d7d. Read the comment docs.

@chapulina chapulina merged commit eaeddf9 into gazebosim:ign-gazebo5 Jul 12, 2021
@ddengster ddengster deleted the feature/tutorial_blender_sdf_export branch July 13, 2021 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏢 edifice Ignition Edifice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants