Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation for the Sensor component #898

Merged
merged 1 commit into from
Jul 1, 2021

Conversation

adlarkin
Copy link
Contributor

@adlarkin adlarkin commented Jul 1, 2021

Signed-off-by: Ashton Larkin [email protected]

The Sensor component had a typo (link was used instead of sensor), so this is a quick fix.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@adlarkin adlarkin requested a review from chapulina as a code owner July 1, 2021 22:01
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Jul 1, 2021
@codecov
Copy link

codecov bot commented Jul 1, 2021

Codecov Report

Merging #898 (55b887b) into ign-gazebo3 (dd9f7b5) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo3     #898      +/-   ##
===============================================
- Coverage        77.94%   77.94%   -0.01%     
===============================================
  Files              215      215              
  Lines            12077    12077              
===============================================
- Hits              9414     9413       -1     
- Misses            2663     2664       +1     
Impacted Files Coverage Δ
include/ignition/gazebo/components/Sensor.hh 100.00% <ø> (ø)
src/Server.cc 82.80% <0.00%> (-0.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd9f7b5...55b887b. Read the comment docs.

@chapulina chapulina merged commit 15b456b into ign-gazebo3 Jul 1, 2021
@chapulina chapulina deleted the adlarkin/sensor_comp_doc_fix branch July 1, 2021 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants