Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drag and drop mesh into scene #924

Closed
wants to merge 1 commit into from
Closed

Drag and drop mesh into scene #924

wants to merge 1 commit into from

Conversation

jennuine
Copy link
Contributor

🎉 New feature

Summary

Allows a user to drag and drop a DAE or STL mesh into the scene.

Peek 2021-07-21 13-41

Test it

  1. ign gazebo -v 4
  2. Drag a DAE or STL model and drop it into the scene

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@jennuine
drag and drop mesh
c13ff00 
Signed-off-by: Jenn Nguyen <[email protected]>
@jennuine jennuine requested a review from chapulina as a code owner July 21, 2021 20:52
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Jul 21, 2021
@chapulina chapulina added the GUI Gazebo's graphical interface (not pure Ignition GUI) label Jul 22, 2021
ahcorde
ahcorde requested changes Jul 22, 2021
View reviewed changes
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any chance to retarget this to ign-gazebo3 ?

@jennuine jennuine changed the base branch from main to ign-gazebo3 July 22, 2021 15:23
@jennuine jennuine requested review from azeey and iche033 as code owners July 22, 2021 15:23
@jennuine jennuine changed the base branch from ign-gazebo3 to main July 22, 2021 15:29
@azeey azeey removed their request for review July 22, 2021 16:45
@jennuine
Copy link
Contributor Author

Is there any chance to retarget this to ign-gazebo3 ?

Yes, will open a new PR to target ign-gazebo3

@jennuine jennuine closed this Jul 22, 2021
@jennuine jennuine deleted the jennuine/import_mesh branch July 28, 2021 22:43
@jennuine
Copy link
Contributor Author

New PR targeting ign-gazebo3: #939

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde requested changes

@chapulina chapulina Awaiting requested review from chapulina

@iche033 iche033 Awaiting requested review from iche033

Assignees
No one assigned
Labels
🏯 fortress Ignition Fortress GUI Gazebo's graphical interface (not pure Ignition GUI)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jennuine @ahcorde @chapulina