Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drag and drop mesh into scene #939
Drag and drop mesh into scene #939
Changes from all commits
2250156
f0de28d
bf77312
7717bac
0db584a
805bd9b
38893b9
7b1c514
2d6a930
0fd716f
0b8dcfb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
popupError()
needs to be formatted as such for the QML connection to work properly: https://github.com/ignitionrobotics/ign-gazebo/blob/0db584abf7efcc97cfc03946ea33d5130e13e410/src/gui/plugins/scene3d/GzScene3D.qml#L105Similar to
openContextMenu
:https://github.com/ignitionrobotics/ign-gazebo/blob/0db584abf7efcc97cfc03946ea33d5130e13e410/src/gui/plugins/scene3d/Scene3D.hh#L717-L721
I've added the same comment from
openContextMenu
topopupError
805bd9b