Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4 ➡️ 5 #948

Merged
merged 8 commits into from
Jul 31, 2021
Merged

4 ➡️ 5 #948

merged 8 commits into from
Jul 31, 2021

Conversation

chapulina
Copy link
Contributor

➡️ Forward port

Port ign-gazebo4 to ign-gazebo5

Branch comparison: ign-gazebo5...ign-gazebo4

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

chapulina and others added 7 commits July 29, 2021 10:58
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Jenn Nguyen <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>

Co-authored-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Jul 30, 2021
chapulina added a commit that referenced this pull request Jul 30, 2021
@codecov
Copy link

codecov bot commented Jul 30, 2021

Codecov Report

Merging #948 (1e49379) into ign-gazebo5 (f9e3332) will increase coverage by 0.44%.
The diff coverage is 66.70%.

❗ Current head 1e49379 differs from pull request most recent head 09e2ea7. Consider uploading reports for the commit 09e2ea7 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo5     #948      +/-   ##
===============================================
+ Coverage        65.31%   65.76%   +0.44%     
===============================================
  Files              240      246       +6     
  Lines            17635    18788    +1153     
===============================================
+ Hits             11519    12355     +836     
- Misses            6116     6433     +317     
Impacted Files Coverage Δ
include/ignition/gazebo/EntityComponentManager.hh 100.00% <ø> (ø)
include/ignition/gazebo/Link.hh 100.00% <ø> (ø)
include/ignition/gazebo/Model.hh 100.00% <ø> (ø)
include/ignition/gazebo/SdfEntityCreator.hh 100.00% <ø> (ø)
include/ignition/gazebo/Server.hh 100.00% <ø> (ø)
include/ignition/gazebo/components/Sensor.hh 100.00% <ø> (ø)
src/gui/Gui.cc 65.35% <ø> (+0.23%) ⬆️
src/gui/GuiRunner.cc 85.91% <0.00%> (+0.38%) ⬆️
.../plugins/component_inspector/ComponentInspector.cc 6.69% <0.00%> (-0.35%) ⬇️
src/gui/plugins/scene3d/Scene3D.hh 50.00% <ø> (-16.67%) ⬇️
... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24be610...09e2ea7. Read the comment docs.

@chapulina chapulina merged commit 9fbb9b9 into ign-gazebo5 Jul 31, 2021
@chapulina chapulina deleted the chapulina/4_to_5 branch July 31, 2021 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏢 edifice Ignition Edifice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants