Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4 ➡️ 5 #968

Merged
merged 19 commits into from
Aug 12, 2021
Merged

4 ➡️ 5 #968

merged 19 commits into from
Aug 12, 2021

Conversation

chapulina
Copy link
Contributor

➡️ Forward port

Port ign-gazebo4 to ign-gazebo5

Branch comparison: ign-gazebo5...ign-gazebo4

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

diegoferigo and others added 17 commits August 2, 2021 10:39
@diegoferigo
Fix logic to disable server default plugins loading (#953)
ad27b27 
Signed-off-by: Diego <[email protected]>
@chapulina
Expose a test fixture helper class (#926)
8620011 
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
@herobank110 @chapulina
Add 25percent darker view angle icons (#426)
0431f9e 
Signed-off-by: David Kanekanian <[email protected]>
@joxoby @chapulina
No install apt recommends and clear cache (#423)
a299095 
Signed-off-by: Juan Oxoby <[email protected]>

Co-authored-by: Juan Oxoby <[email protected]>
Co-authored-by: Louise Poubel <[email protected]>
@j-rivero @chapulina
Fix visibility macro names when used by a different component (Window…
bcef509 
…s) (#564)

Signed-off-by: Jose Luis Rivero <[email protected]>
@j-rivero @chapulina
Add missing IGNITION_GAZEBO_VISIBLE macros (#563)
dc50b29 
Signed-off-by: Jose Luis Rivero <[email protected]>
@chapulina
Examples and tutorial on using rendering API from plugins (#596)
7f711e0 
Signed-off-by: Louise Poubel <[email protected]>

Edifice to Citadel (#945)

Signed-off-by: Louise Poubel <[email protected]>
@chapulina
Setting the intiial velocity for a model or joint (#693)
c093937 
Signed-off-by: Louise Poubel <[email protected]>
@ammaar8 @chapulina
Add UserCommands Plugin. (#719)
17aa8f5 
Signed-off-by: Ammaar Solkar <[email protected]>
@chapulina @ahcorde
Fix component inspector shutdown crash (#724)
0f49361 
Signed-off-by: Louise Poubel <[email protected]>

Co-authored-by: Alejandro Hernández Cordero <[email protected]>
@doisyg @chapulina
[DiffDrive] add enable/disable (#772)
a83f56f 
* add enable/disable diffdrive

Signed-off-by: Guillaume Doisy <[email protected]>

* remove debug

Signed-off-by: Guillaume Doisy <[email protected]>

* do not subscribe to enable if topic is empty

Signed-off-by: Guillaume Doisy <[email protected]>

* add test

Signed-off-by: Guillaume Doisy <[email protected]>

* lint and style

Signed-off-by: Guillaume Doisy <[email protected]>

* change enable type to bool and renamed to enabled

Signed-off-by: Guillaume Doisy <[email protected]>
@traversaro
Set protobuf_MODULE_COMPATIBLE before any find_package call (#957)
c57b3c9 
Signed-off-by: Silvio Traversaro <[email protected]>
@jennuine @mjcarroll
Drag and drop meshes into scene (#939)
b7346a4 
Signed-off-by: Jenn Nguyen <[email protected]>

Co-authored-by: Michael Carroll <[email protected]>
@chapulina
Be more specific when looking for physics plugins (#965)
0f58670 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
3 -> 4 (#964)
bec5f8a 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
3 -> 4 fixes (#964)
e95f17c 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
3 ➡️ 4 (#964)
34eb437 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina requested a review from azeey as a code owner August 11, 2021 15:59
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Aug 11, 2021
luca-della-vedova and others added 2 commits August 12, 2021 07:06
@luca-della-vedova @iche033
Fix crash in the follow_actor example (#958)
fbe137e 
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Ian Chen <[email protected]>

Co-authored-by: Ian Chen <[email protected]>
@chapulina
4 ➡ 5 (#968)
ae8eb2e 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina requested a review from iche033 as a code owner August 12, 2021 15:25
@codecov
Copy link

codecov bot commented Aug 12, 2021 •
edited
Loading

Codecov Report

Merging #968 (ae8eb2e) into ign-gazebo5 (1e49379) will increase coverage by 0.89%.
The diff coverage is 64.08%.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo5     #968      +/-   ##
===============================================
+ Coverage        65.76%   66.65%   +0.89%     
===============================================
  Files              246      247       +1     
  Lines            18788    18900     +112     
===============================================
+ Hits             12355    12598     +243     
+ Misses            6433     6302     -131
Impacted Files Coverage Δ
src/ServerConfig.cc 89.68% <ø> (ø)
src/gui/plugins/scene3d/Scene3D.hh 50.00% <ø> (ø)
src/systems/lift_drag/LiftDrag.hh 100.00% <ø> (ø)
src/systems/velocity_control/VelocityControl.hh 100.00% <ø> (ø)
src/gui/plugins/scene3d/Scene3D.cc 10.41% <7.69%> (-0.04%) ⬇️
src/systems/lift_drag/LiftDrag.cc 62.85% <18.51%> (-7.08%) ⬇️
src/systems/physics/Physics.cc 70.27% <20.00%> (-0.20%) ⬇️
src/systems/joint_controller/JointController.cc 81.81% <90.90%> (+3.24%) ⬆️
include/ignition/gazebo/Util.hh 100.00% <100.00%> (ø)
src/TestFixture.cc 100.00% <100.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5eff5f8...ae8eb2e. Read the comment docs.

ahcorde
ahcorde reviewed Aug 12, 2021
View reviewed changes
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows CI is failing

@chapulina
Copy link
Contributor Author

Windows CI is failing

I think that was a spurious failure, the latest build is good 🙌

@chapulina chapulina merged commit 0c401c1 into ign-gazebo5 Aug 12, 2021
@chapulina chapulina deleted the chapulina/4_to_5 branch August 12, 2021 22:32
@diegoferigo diegoferigo mentioned this pull request Aug 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde left review comments

@mjcarroll mjcarroll mjcarroll approved these changes

@azeey azeey Awaiting requested review from azeey azeey is a code owner

@iche033 iche033 Awaiting requested review from iche033 iche033 is a code owner

Assignees
No one assigned
Labels
🏢 edifice Ignition Edifice
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.