Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3 ➡️ 4 #973

Merged
merged 4 commits into from
Aug 24, 2021
Merged

3 ➡️ 4 #973

merged 4 commits into from
Aug 24, 2021

Conversation

chapulina
Copy link
Contributor

➡️ Forward port

Port ign-gazebo3 to ign-gazebo4

Branch comparison: ign-gazebo4...ign-gazebo3

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

@chapulina chapulina requested a review from azeey as a code owner August 13, 2021 22:15
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Aug 13, 2021
@codecov
Copy link

codecov bot commented Aug 13, 2021

Codecov Report

Merging #973 (ba98a7d) into ign-gazebo4 (9691622) will decrease coverage by 0.01%.
The diff coverage is 66.66%.

❗ Current head ba98a7d differs from pull request most recent head d00a48e. Consider uploading reports for the commit d00a48e to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo4     #973      +/-   ##
===============================================
- Coverage        67.12%   67.11%   -0.02%     
===============================================
  Files              243      243              
  Lines            18207    18209       +2     
===============================================
- Hits             12222    12221       -1     
- Misses            5985     5988       +3     
Impacted Files Coverage Δ
src/ServerPrivate.cc 86.93% <ø> (-0.22%) ⬇️
src/ServerConfig.cc 89.03% <66.66%> (-0.65%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9691622...d00a48e. Read the comment docs.

@chapulina chapulina requested a review from ahcorde August 23, 2021 18:45
@chapulina chapulina merged commit 9cafd6d into ign-gazebo4 Aug 24, 2021
@chapulina chapulina deleted the chapulina/3_to_4 branch August 24, 2021 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants