Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ESC to unselect entities in select entities plugin #995

Merged
merged 3 commits into from
Aug 26, 2021

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Aug 25, 2021

🦟 Bug fix

Summary

ESC to unselect entities

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@ahcorde ahcorde requested a review from chapulina August 25, 2021 13:14
@ahcorde ahcorde self-assigned this Aug 25, 2021
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Aug 25, 2021
@codecov
Copy link

codecov bot commented Aug 25, 2021

Codecov Report

Merging #995 (74715e1) into main (1334b5c) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 74715e1 differs from pull request most recent head 438ebba. Consider uploading reports for the commit 438ebba to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #995      +/-   ##
==========================================
- Coverage   63.79%   63.78%   -0.01%     
==========================================
  Files         246      246              
  Lines       19996    19996              
==========================================
- Hits        12756    12755       -1     
- Misses       7240     7241       +1     
Impacted Files Coverage Δ
src/gui/plugins/plot_3d/Plot3D.cc 43.47% <0.00%> (-4.35%) ⬇️
src/SimulationRunner.cc 93.90% <0.00%> (+1.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1334b5c...438ebba. Read the comment docs.

@ahcorde ahcorde mentioned this pull request Aug 25, 2021
8 tasks
@chapulina chapulina added the GUI Gazebo's graphical interface (not pure Ignition GUI) label Aug 26, 2021
@ahcorde
Copy link
Contributor Author

ahcorde commented Aug 26, 2021

@osrf-jenkins retest this please

@ahcorde ahcorde merged commit 628fe9e into main Aug 26, 2021
@ahcorde ahcorde deleted the ahcorde/selectEntities/ESC branch August 26, 2021 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress GUI Gazebo's graphical interface (not pure Ignition GUI)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants