Source bash completion files for all other gz libraries #104
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Toward #1
Replaces #103 (Creating a new PR with a branch on the upstream repo instead of a fork so I can test with a debbuilder job).
Summary
Source the
gz*.completion
file from wherever its installed so that the bash completion functions for other gz libraries can be picked up automatically.Additionally, this installed the cmake configured
etc/ign.bash_completion.sh
file to<prefix>/share/bash-completion/completions/ign
instead of relying on the debian/homebrew build infrastructure (see gazebo-release/gz-tools-release#6). This has two advantages (1) makes it easy to use the cmake configured file so we can have cmake variables inetc/ign.bash_completion.sh
(2) tab completion works the same way when building from source if<prefix>
is set to/usr
.Related:
gazebo-release/gz-tools-release#6
Test it
To build this with gazebo-release/gz-tools-release#6 on focal, symlink
gz-tools-release/focal/debian
into the the root directory ofgz-tools
, then from the root directory ofgz-tools
, build the deb files usingdpkg-buildpackage -us -uc -b
. The deb files will be created in the parent directory. You can then copy the debs to a docker container, install it, and test tab completion.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.