Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent empty messages from spamming the console. #164

Merged
merged 1 commit into from
Aug 26, 2020

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Aug 26, 2020

A topic could publish an Int32 or Int64 message with data=0. In this situation the protobuf message has size zero. While this is not a problem for protobuf messages, it is considered an error for SQLite3.

Added logic to prevent console spamming.

Signed-off-by: Nate Koenig [email protected]

@nkoenig nkoenig requested a review from caguero August 26, 2020 14:08
@github-actions github-actions bot added the 📜 blueprint Ignition Blueprint label Aug 26, 2020
@codecov
Copy link

codecov bot commented Aug 26, 2020

Codecov Report

Merging #164 into ign-transport7 will decrease coverage by 0.01%.
The diff coverage is 25.00%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           ign-transport7     #164      +/-   ##
==================================================
- Coverage           89.75%   89.73%   -0.02%     
==================================================
  Files                  49       49              
  Lines                4793     4795       +2     
==================================================
+ Hits                 4302     4303       +1     
- Misses                491      492       +1     
Impacted Files Coverage Δ
log/src/Recorder.cc 87.20% <0.00%> (ø)
log/src/Log.cc 78.72% <33.33%> (-0.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e828c4a...aee2260. Read the comment docs.

Copy link
Collaborator

@caguero caguero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That protobuf behavior for default values might be more efficient but it's super annoying. I remember hitting us multiple times.

@nkoenig nkoenig merged commit d7283a4 into ign-transport7 Aug 26, 2020
@nkoenig nkoenig deleted the empty_msg_spam branch August 26, 2020 20:46
@chapulina chapulina mentioned this pull request Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📜 blueprint Ignition Blueprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants