Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Bump main to 10.0.0~pre1 #188

Merged
merged 1 commit into from
Oct 9, 2020
Merged

⬆️ Bump main to 10.0.0~pre1 #188

merged 1 commit into from
Oct 9, 2020

Conversation

chapulina
Copy link
Contributor

The ign-transport9 branch was created off main for the Dome release.

Now bumping main to version 10 so it may receive breaking changes.

Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina requested a review from caguero as a code owner October 8, 2020 01:18
@codecov
Copy link

codecov bot commented Oct 8, 2020

Codecov Report

Merging #188 into main will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #188      +/-   ##
==========================================
- Coverage   88.96%   88.84%   -0.12%     
==========================================
  Files          47       48       +1     
  Lines        4484     4508      +24     
==========================================
+ Hits         3989     4005      +16     
- Misses        495      503       +8     
Impacted Files Coverage Δ
src/TopicUtils.cc
include/ignition/transport/Clock.hh
src/Helpers.cc
src/Publisher.cc
src/SubscriptionHandler.cc
src/Clock.cc
log/src/Descriptor.cc
src/SubscribeOptionsPrivate.hh
log/src/QueryOptions.cc
log/src/Message.cc
... and 85 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b3a3e0...48d1752. Read the comment docs.

@chapulina
Copy link
Contributor Author

I'm looking into fixing the Jenkins Ubuntu build

@chapulina
Copy link
Contributor Author

I'm looking into fixing the Jenkins Ubuntu build

I see @scpeters fixed it in gazebo-tooling/release-tools#316, but I also proposed a long-term solution in gazebo-tooling/release-tools#317.

CI is running again.

@chapulina
Copy link
Contributor Author

CI is running again.

Ah no, that says if [[ ${IGN_TRANSPORT_MAJOR_VERSION} -eq 9 ]], so we need to wait for gazebo-tooling/release-tools#317 or another fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants