Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add parameters component #304

Closed
wants to merge 10 commits into from
Closed

Add parameters component #304

wants to merge 10 commits into from

Conversation

ivanpauno
Copy link
Contributor

🎉 New feature

Replaces gazebosim/gz-sim#1280.

Summary

Adds an implementation of a parameter registry, which allows through services to:

  • Declare a parameter.
  • Get the value of a parameter.
  • Set the value of a parameter.
  • List all parameters.

The same operations can be done directly locally, using the parameters registry API.
There's also a parameters client implementation, which is just a wrapper on top of sending requests to the services.

TODO:

  • Add tests!!!
  • Open PR in ignition gazebo using this!!!

Test it

TODO

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

@ivanpauno ivanpauno added the enhancement New feature or request label Mar 30, 2022
@ivanpauno ivanpauno self-assigned this Mar 30, 2022
@ivanpauno ivanpauno changed the base branch from ign-transport11 to ign-transport10 March 30, 2022 20:43
@ivanpauno
wip
515672f 
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
@ivanpauno
wip
6b07b82 
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
@ivanpauno
wip
50e147d 
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
@ivanpauno
Complete implementation of parameters::Registry class
45253cc 
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
@ivanpauno
Use const std::string & when appropriate
8ab985c 
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
@ivanpauno
First ParameterClient implementation
2e9b9ca 
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
@ivanpauno
Add ListParameters() to both registry and client
5d4e673 
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
@ivanpauno
Fix
886f14d 
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
@ivanpauno ivanpauno force-pushed the ivanpauno/parameters-component branch from dc90902 to 886f14d Compare March 30, 2022 20:44
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Mar 30, 2022
ivanpauno added 2 commits April 5, 2022 17:51
@ivanpauno
Fix declare parameter
22a2718 
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
@ivanpauno
Add command line API for param
a9db5b1 
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
@ivanpauno
Copy link
Contributor Author

I will open a PR targetting ignition-transport11 instead.

@ivanpauno ivanpauno closed this Apr 8, 2022
@ivanpauno ivanpauno mentioned this pull request Apr 8, 2022
Merged
10 tasks
@ivanpauno ivanpauno deleted the ivanpauno/parameters-component branch April 8, 2022 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caguero caguero Awaiting requested review from caguero caguero will be requested when the pull request is marked ready for review caguero is a code owner

Assignees

@ivanpauno ivanpauno

Labels
enhancement New feature or request 🏯 fortress Ignition Fortress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ivanpauno