-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implptr Get function #27
Conversation
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
Co-authored-by: Louise Poubel <[email protected]>
Ign util1 to main
Signed-off-by: Nate Koenig <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-utils1 #27 +/- ##
==============================================
+ Coverage 89.58% 94.00% +4.41%
==============================================
Files 3 3
Lines 48 50 +2
==============================================
+ Hits 43 47 +4
+ Misses 5 3 -2
Continue to review full report at Codecov.
|
Can this target |
Signed-off-by: Nate Koenig <[email protected]>
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment regarding what seems to be duplicate tests. Otherwise, LGTM!
Signed-off-by: Nate Koenig <[email protected]>
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1 |
🎉 New feature
Summary
Adds a get function to the ImplPtr class so that you can do things like:
Test it
Run the tests.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge