-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NeverDestroyed utility class #31
Conversation
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
@jwnimmer-tri based on your comment on the ign-math issue above, we have decided to move forward with this option for classes such as Would it be possible for you to sign off on relicensing this to Apache 2.0? While BSD is compatible, for the ease of packaging, it helps to have as few different licenses as possible. I have deferred adding any sort of license/copyright header until I get confirmation from you. |
Yes, given the git history of the header and test code, TRI (me) are the sole author. TRI (and me) grant you license under Apache-2.0 terms to contribute it here. |
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]> Co-authored-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
5d03795
to
363b408
Compare
Signed-off-by: Addisu Z. Taddese <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-utils1 #31 +/- ##
==============================================
+ Coverage 94.36% 94.87% +0.50%
==============================================
Files 4 5 +1
Lines 71 78 +7
==============================================
+ Hits 67 74 +7
Misses 4 4
Continue to review full report at Codecov.
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1 |
🎉 New feature
Summary
Useful for function-local static variables that are not trivially destructable. This can be used to clean up "possible leak" warnings from memory-checking tools.
Originally imported from drake codebase (BSD 3-clause). It has been updated for consistency with ignition codebase.
Added in support of gazebosim/gz-math#269 at the suggestion of @jwnimmer-tri (gazebosim/gz-math#269 (comment))
Test it
Unit tests have been imported as well
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge