Fix memory corruption in Ogre2GpuRays (Fortress)

[darksylinc]

Order of destruction was inverted

Signed-off-by: Matias N. Goldberg [email protected]

🦟 Bug fix

No ticket was filed for this bug.

Summary

This bug was discovered thanks to CI and Valgrind in PR #785

This is a backport to Fortress.

Checklist

• Signed all commits for DCO
• Added tests
• Updated documentation (as needed)
• Updated migration guide (as needed)
• Consider updating Python bindings (if the library has them)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

[codecov]

Codecov Report

Merging #787 (07aa91b) into ign-rendering6 (e6c3b72) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@               Coverage Diff               @@
##           ign-rendering6     #787   +/-   ##
===============================================
  Coverage           77.84%   77.85%           
===============================================
  Files                 146      146           
  Lines               13404    13404           
===============================================
+ Hits                10435    10436    +1     
+ Misses               2969     2968    -1     

Impacted Files	Coverage Δ
ogre2/src/Ogre2GpuRays.cc	95.51% <100.00%> (ø)
...e/ignition/rendering/base/BaseGaussianNoisePass.hh	100.00% <0.00%> (+3.33%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.