Add wide angle camera sensor #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
8 tasks
Signed-off-by: Ian Chen <[email protected]>
|
Sensor is working as expected and the tests passes for me! |
WilliamLewww
approved these changes
Dec 3, 2021
chapulina
added
the
needs upstream release
Codecov Report
@@ Coverage Diff @@
## main #171 +/- ##
==========================================
- Coverage 75.96% 70.31% -5.65%
==========================================
Files 27 28 +1
Lines 2754 2975 +221
==========================================
Hits 2092 2092
- Misses 662 883 +221
Continue to review full report at Codecov.
|
chapulina
removed
the
needs upstream release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
depends on:
Summary
Added a wide angle camera sensor. The bulk of the work for generating wide angle camera data is done in gazebosim/gz-rendering#490. This PR adds logic to package the image data and publish them through ign-transport and event callbacks.
Test it
added a
wide_angle_cameraintegration test. Run the test withogrerender engine from your colcon workspace:Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge